Bug #1611: Squish remaining "rake rails:upgrade:check" warnings

Comments

1. Greg Hurrell 2010-07-15T13:40:50Z

   Apart from a bunch of false positives due to the overly lax regular expressions in the plug-in, the only warnings left are the following:

   Soon-to-be-deprecated ActiveRecord calls
   Methods such as find(:all), find(:first), finds with conditions, and the :joins option will soon be deprecated.
   More information: http://m.onkey.org/2010/1/22/active-record-query-interface
   
   The culprits: 
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/controllers/admin/posts_controller.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/controllers/users_controller.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/models/issue.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/models/needle.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/models/tagging.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/controllers/comments_controller.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/controllers/dashboard_controller.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/controllers/issues_controller.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/controllers/resets_controller.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/controllers/tags_controller.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/controllers/topics_controller.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/controllers/users_controller.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/models/forum.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/models/needle.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/models/tag.rb
   	- /Users/wincent/trabajo/unversioned/wincent.dev/src/app/models/tagging.rb

   Haven't checked them out yet, so not sure if they are all legit.

2. Greg Hurrell 2010-07-15T17:11:28Z

   Currently knocking off the find :all, :conditions => ... and find ..., :conditions => ... type queries.

   Need to remember to go back and do another pass for count queries and perhaps others too.

3. Greg Hurrell 2010-07-16T16:33:34Z

   Think this is all done now.

4. Greg Hurrell 2010-07-16T16:33:44Z

   Status changed:

   • From: new
   • To: closed

Add a comment

Comments are now closed for this issue.