≡

wincent.dev

  • Products
  • Blog
  • Wiki
  • Issues
You are viewing an historical archive of past issues. Please report new issues to the appropriate project issue tracker on GitHub.
Home » Issues » Feature request #2190

Feature request #2190: Rename CommandTTraverseSCM's "pwd" to "cwd"

Kind feature request
Product Command-T
When Created 2014-12-30T23:25:53Z, updated 2015-01-12T18:54:15Z
Status closed
Reporter Andri Moell
Tags no tags

Description

Hey,

The CommandTTraverseSCM option takes a value of pwd. PWD AFAIK stands for "print working directory" which in this context is weird. It'd be better named cwd (current working directory).

Comments

  1. Greg Hurrell 2014-12-31T10:37:53Z

    Thanks for posting, Andri.

    It's true that in the Vim help for :pwd, it says:

    Print the current directory name

    The value in Command-T is named "pwd" not because there's any printing involved, but because the value that gets used is obtained by running the Vim :pwd command. I don't think the name should be changed now, as it could break people's existing configs that use the name (and accepting both names in the interests of backwards compatibility is just cluttering up the codebase for little pay-off).

    For what it's worth, the Command-T docs for the "pwd" say this:

    use Vim's present working directory as a root

    So there's another reason why "pwd" is totally reasonable; it's an acronym for "present working directory".

  2. Greg Hurrell 2014-12-31T10:37:56Z

    Status changed:

    • From: new
    • To: closed
  3. Andri Moell 2015-01-05T20:03:12Z

    Sorry for the off-topic, but is there a way to get email notifications from here? Just came to report another bug and only now saw this bug addressed.

  4. Andri Moell Created 2015-01-05T20:14:59Z, edited 2015-01-07T11:09:10Z

    Okay, your call. I still think pwd is a name that should die as even in Vim context it stands for "print". :)

        getcwd()	The result is a String, which is the name of the current
    		working directory.
    
        :pw[d]	Print the current directory name.  {Vi: no pwd}
    		Also see |getcwd()|.
  5. Greg Hurrell 2015-01-07T11:11:21Z

    I still think pwd is a name that should die as even in Vim context it stands for "print".

    Yeah, I know, but I don't want to go breaking compatibility with people's existing configurations.

    As for email notifications, it's a half-implemented feature; I need to get off my butt and finish implementing it. I used to have Atom feeds that people could subscribe to, but I eventually removed those when one of many Rails upgrades broke the feature and I didn't have time to fix it.

  6. Andri Moell 2015-01-12T14:00:32Z

    You _could_ just deprecate pwd, add cwd and keep pwd forever. That's the price to pay for poor previous decisions. :)

    As for email notifications, it's a half-implemented feature;

    Any particular reason to use a custom issue tracker over something OSS or one of those code hosting sites? All I see is more trouble and pain for the "customers", if you like to call them that.

  7. Greg Hurrell 2015-01-12T18:54:15Z

    You _could_ just deprecate pwd, add cwd and keep pwd forever. That's the price to pay for poor previous decisions.

    On the scale of "poor" decisions, this particular one is utterly innocuous, so it's simply not worth paying the price; as I said above:

    accepting both names in the interests of backwards compatibility is just cluttering up the codebase for little pay-off

    (And yes, arguing here about whether to make the change constitutes a price as well, but I'd rather bicker here than incur a cost in the code itself.)

    As for the tracker: I used to use OSS for everything and for the bugtracker, specifically, Bugzilla. But it was a pain for most users, especially users of my less-technical software (ie. not Command-T). I replaced a bunch of separate, disconnected open source software for the tracker, forums, wiki, blog etc with a single Rails app, which ended up being a net win. I'm a big fan of open source myself; the only reason this website's source isn't open is that I haven't gotten around to it yet.

    You're also free to report issues on the GitHub project if you prefer that interface (https://github.com/wincent/command-t/issues); it's evidently much more sophisticated than the tracker here, but years ago when all this was made GitHub barely existed, and I don't think it had an issue tracker at all back then.

Add a comment

Comments are now closed for this issue.

  • contact
  • legal

Menu

  • Blog
  • Wiki
  • Issues
  • Snippets