You are viewing an historical archive of past issues. Please report new issues to the appropriate project issue tracker on GitHub.

Bug #1288: AJAX product pop-up always set to "no product" (blank) in issues#show

Kind bug
Product wincent.dev
When
Status closed
Reporter Greg Hurrell
Tags no tags

Description

none

Comments

  1. Greg Hurrell

    Status changed:

    • From: New
    • To: Open
  2. Greg Hurrell

    The pop-up is not broken for all products. Some examples:

    Basically looks like all are broken except for the wincent.dev tickets.

  3. Greg Hurrell

    Broken

    Working

    Unknown

    There are a few products for which there aren't any tickets, so I don't know if they work:

    • WOHotKey
    • Walrus
    • etc...
  4. Greg Hurrell

    As a first guess I'd say we have a case-sensitivity issue here.

  5. Greg Hurrell

    Ok, as the fix was pretty minor (see below), I've just uploaded a new ajax.js file rather than doing a full deployment: 

    diff --git a/public/javascripts/ajax.js b/public/javascripts/ajax.js
index e1dee88..3c98f23 100644
--- a/public/javascripts/ajax.js
+++ b/public/javascripts/ajax.js
@@ -133,14 +133,14 @@ function ajax_select(selector, class_name, attribute_name, options, include_blan
   var model_id = $(selector).attr('id'); // issue_22
   var record_id = model_id.match(/_(\d+)$/)[1]; // 22
   var field_id = $('#' + model_id + '_' + attribute_name); // issue_22_status
-  var field_text = field_id.text(); // eg. New, Open, Closed (first letter capitalized by humanize method)
+  var field_text = field_id.text(); // eg. New, Open, Closed
   var new_contents = '<select id="' + class_name + '_' + attribute_name + '" name="' + class_name + '[' + attribute_name + ']">';
   if (include_blank) {
     new_contents = new_contents + '<option value=""></option>';
   }
   var selection_found = false;
   for (var i = 0; i < options.length; i++) {
-    if (field_text.toLowerCase() == options[i][0]) {
+    if (field_text.toLowerCase() == options[i][0].toLowerCase()) {
       new_contents = new_contents + '<option value="' + options[i][1] + '" selected="selected">' + options[i][0] + '</option>';
       selection_found = true;
     } else {
  6. Greg Hurrell

    Status changed:

    • From: Open
    • To: Closed
Add a comment

Comments are now closed for this issue.

Menu